fixed some typos in ft_util.scad and removed code which has been commented out
This commit is contained in:
+5
-19
@@ -17,7 +17,7 @@
|
||||
// values in OpenSCAD are constants technically spoken, these are some
|
||||
// kind of special. They define standard values used everywhere and
|
||||
// changing them might influence how a part is redered and exported
|
||||
// to the finsal stl file for printing.
|
||||
// to the final stl file for printing.
|
||||
|
||||
// The standard grid size of fischertechnik parts is 15 mm. Most
|
||||
// parts fit into that grid.
|
||||
@@ -156,29 +156,15 @@ module eyelet(height = EYELET_HEIGHT, radius=2.05,
|
||||
correctionVal = 0.0)
|
||||
{
|
||||
// Currently used only in the lugs.scad file
|
||||
// See strut_eyelet to decide whether that one can be refactored
|
||||
// or replaced by this library module.
|
||||
// See strut_eyelet to decide whether that one can be refactored
|
||||
// or replaced by this library module.
|
||||
|
||||
render()
|
||||
union()
|
||||
{
|
||||
// radius = apply_correction(radius, correctionVal, horizontal);
|
||||
// cube_width = apply_correction(7.2, correctionVal, horizontal);
|
||||
// cube_height = apply_correction(3.1, correctionVal, horizontal);
|
||||
|
||||
// Hmm, horizontal=true raises the eylet above the z axis while
|
||||
// horizontal=false move the eyelet below the z axis.
|
||||
// Is this intended? I assume no, all usages force the eyelet
|
||||
// into horizontal= true. I would suggest that the eyelet cutout
|
||||
// is centered on all four axises and the the horizontal= true
|
||||
// forces the eyelet into x direction while false forces it into
|
||||
// y direction.
|
||||
// translate([0, 0, horizontal == false ? -(height/2) + MANIFOLD_CORRECTION : (height/2) - MANIFOLD_CORRECTION ])
|
||||
// {
|
||||
cylinder(h = height, r = radius, center = true);
|
||||
// cube([cube_height, cube_width, height], center = true);
|
||||
cube([cube_width, cube_len, height], center = true);
|
||||
// }
|
||||
cylinder(h = height, r = radius, center = true);
|
||||
cube([cube_width, cube_len, height], center = true);
|
||||
}
|
||||
}
|
||||
|
||||
|
||||
Reference in New Issue
Block a user